Skip to content

Fixes #262 by updating keyword documentation - #613

Merged
aaltat merged 1 commit into
robotframework:masterfrom
aaltat:jQuery_is_not_provided_by_Selenium2Library
Dec 29, 2016
Merged

Fixes #262 by updating keyword documentation#613
aaltat merged 1 commit into
robotframework:masterfrom
aaltat:jQuery_is_not_provided_by_Selenium2Library

Conversation

@aaltat

@aaltat aaltat commented Jun 13, 2016

Copy link
Copy Markdown
Contributor

Updates Wxecute Javascript keyword the documentation to mention that javascript is not provided by the Selenium2Library

@aaltat aaltat mentioned this pull request Jun 13, 2016
Closed
@HelioGuilherme66

HelioGuilherme66 commented Jun 13, 2016

Copy link
Copy Markdown
Member

Well, you have a typo ;).
(you have "not" instead of "note")

"Please note that JavaScript ..."

How about expanding to:
"Please note that JavaScript (or any derivative/wrapper, like for example JQuery) ..."

@aaltat

aaltat commented Jun 13, 2016

Copy link
Copy Markdown
Contributor Author

Good catch @HelioGuilherme66, fixed.

@aaltat

aaltat commented Jun 13, 2016

Copy link
Copy Markdown
Contributor Author

There are some many wrappers... Perhaps it would be best only to say javascript?

@aaltat

aaltat commented Jun 15, 2016

Copy link
Copy Markdown
Contributor Author

Moved documentation from the keyword to library level, based on ed comments on #262

emanlove
emanlove reviewed Jun 15, 2016
View reviewed changes
Comment thread src/Selenium2Library/__init__.py
Please note that JavaScript is not provided by Selenium2Library and
if there is need to use JavaScript must be provided by the system
under test.

@emanlove emanlove Jun 15, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not JavaScript but jQuery. Slightly rewording it might say

Please note that jQuery is not provided by Selenium2Library and if there is need to use jQuery locators, the system under test must provide the jQuery library.

or

In regards to the jQuery locator stratergy, please note that jQuery is not provided by Selenium2Library. If the test uses jQuery locators, the system under test must provide the jQuery library.

@aaltat

aaltat commented Aug 8, 2016

Copy link
Copy Markdown
Contributor Author

I Agree with @emanlove and changed the text based on his comments.

@aaltat

aaltat commented Dec 10, 2016

Copy link
Copy Markdown
Contributor Author

Are we happy with this pull request and it be merged to the master?

@aaltat
aaltat merged commit 87ef128 into robotframework:master Dec 29, 2016
@aaltat
aaltat deleted the jQuery_is_not_provided_by_Selenium2Library branch January 24, 2017 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aaltat @HelioGuilherme66 @emanlove